Found 2 bugs in AN84868's source code (Configuring an FPGA Over USB Using Cypress EZ-USB FX3)

Tip / Sign in to post questions, reply, level up, and achieve exciting badges. Know more

cross mob
arnova
Level 1
Level 1
First reply posted First question asked First like given

While compiling AN84868's source-code I noticed two compiler warnings. One seems harmless, the other could cause potential issues. I've fixed these 2 issues(bugs). I'm not sure where I should normally report these? The diff for the fixes is below. Hopefully it can be picked up by one of the engineers?

diff --git a/ConfigFpgaSlaveFifoSync/cyfxconfigfpga.h b/ConfigFpgaSlaveFifoSync/cyfxconfigfpga.h
index d8e9444..1fc8d92 100644
--- a/ConfigFpgaSlaveFifoSync/cyfxconfigfpga.h
+++ b/ConfigFpgaSlaveFifoSync/cyfxconfigfpga.h
@@ -38,7 +38,7 @@ extern volatile CyBool_t glIsApplnActive;

 extern CyU3PEvent glFxConfigFpgaAppEvent;    /* Configure FPGA event group. */

-extern uint8_t *seqnum_p;
+extern uint8_t seqnum_p;



diff --git a/ConfigFpgaSlaveFifoSync/cyfxslfifosync.c b/ConfigFpgaSlaveFifoSync/cyfxslfifosync.c
index ce9d0e4..3fc76c0 100644
--- a/ConfigFpgaSlaveFifoSync/cyfxslfifosync.c
+++ b/ConfigFpgaSlaveFifoSync/cyfxslfifosync.c
@@ -84,7 +84,8 @@ uint32_t glDMATxCount = 0;               /* Counter to track the number of buffe
 volatile CyBool_t glIsApplnActive = CyFalse;      /* Whether the loopback application is active or not. */
 uint8_t glEp0Buffer[32];                /* Buffer used for sending EP0 data.    */

-uint8_t *seqnum_p;
+uint8_t seqnum_p;


diff --git a/ConfigFpgaSlaveFifoSync/cyfxgpif2config.h b/ConfigFpgaSlaveFifoSync/cyfxgpif2config.h
index 84d7210..0e3d10e 100644
--- a/ConfigFpgaSlaveFifoSync/cyfxgpif2config.h
+++ b/ConfigFpgaSlaveFifoSync/cyfxgpif2config.h
@@ -85,7 +85,7 @@ uint32_t CyFxGpifRegValue[]  = {
     0x80000380,  /*  CY_U3P_PIB_GPIF_CONFIG */
 #if (CY_FX_SLFIFO_GPIF_16_32BIT_CONF_SELECT == 0)
     0x000010A7,  /*  CY_U3P_PIB_GPIF_BUS_CONFIG */
-#else if (CY_FX_SLFIFO_GPIF_16_32BIT_CONF_SELECT ==1)
+#else // if (CY_FX_SLFIFO_GPIF_16_32BIT_CONF_SELECT == 1)
        0x000010AC, /* 32b data- CY_U3P_PIB_GPIF_BUS_CONFIG */
 #endif
     0x01070002,  /*  CY_U3P_PIB_GPIF_BUS_CONFIG2 */

 

0 Likes
1 Solution
Hemanth
Moderator
Moderator
Moderator
First like given First question asked 750 replies posted

Hi,

Thank you very much for pointing out the problems and providing the fix as well!

We will definitely update the app note source code.

Regards,

Hemanth

View solution in original post

0 Likes
1 Reply
Hemanth
Moderator
Moderator
Moderator
First like given First question asked 750 replies posted

Hi,

Thank you very much for pointing out the problems and providing the fix as well!

We will definitely update the app note source code.

Regards,

Hemanth
0 Likes