crash is seen after suspend resume

[vivekpandey]

cyw54591 is crashing after suspend resume.

details crash log is given below:

<0>[165140.146951] Internal error: Oops: 17 [#1] PREEMPT ARM
<4>[165140.146974] Modules linked in: brcmfmac(O) cfg80211(O) brcmutil(O) compat(O) ramoops shortcut_fe_cm shortcut_fe_ipv6 shortcut_fe bq27520_battery_nvtl msm_mnd_buzzer cyttsp5_i2c cyttsp5_loader cyttsp5_device_access cyttsp5 fusb30x_whole smb1351_charger_nvtl
<4>[165140.146981] CPU: 0 PID: 4248 Comm: kworker/0:3 Tainted: G B W O 3.18.71 #1
<4>[165140.147114] Workqueue: events brcmf_core_bus_reset [brcmfmac]

<1>[165140.160119] Unable to handle kernel paging request at virtual address fffffff0
<1>[165140.160123] pgd = c0004000
<1>[165140.160131] [fffffff0] *pgd=9faba841, *pte=00000000, *ppte=00000000
<0>[165140.160137] Internal error: Oops: 27 [#2] PREEMPT ARM
<4>[165140.160158] Modules linked in: brcmfmac(O) cfg80211(O) brcmutil(O) compat(O) ramoops shortcut_fe_cm shortcut_fe_ipv6 shortcut_fe bq27520_battery_nvtl msm_mnd_buzzer cyttsp5_i2c cyttsp5_loader cyttsp5_device_access cyttsp5 fusb30x_whole smb1351_charger_nvtl
<4>[165140.160164] CPU: 0 PID: 4248 Comm: kworker/0:3 Tainted: G B D W O 3.18.71 #1
<4>[165140.160173] task: df1f1080 ti: d0fa0000 task.ti: d0fa0000
<4>[165140.160182] PC is at kthread_data+0x4/0xc
<4>[165140.160187] LR is at wq_worker_sleeping+0xc/0xb4
<4>[165140.160193] pc : [<c003a7e0>] lr : [<c0036db8>] psr: 20030193
<4>[165140.160193] sp : d0fa1c38 ip : 00000000 fp : d0fa1c8c
<4>[165140.160197] r10: 00000000 r9 : df1f0000 r8 : df1f1078
<4>[165140.160201] r7 : c0c5bb58 r6 : 00000001 r5 : d0fa0000 r4 : 00000000
<4>[165140.160205] r3 : 00000000 r2 : 0000263b r1 : 00000000 r0 : df1f1080
<4>[165140.160210] Flags: nzCv IRQs off FIQs on Mode SVC_32 ISA ARM Segment none
<4>[165140.160215] Control: 10c53c7d Table: 98a14059 DAC: 00000051
<0>[165140.160219] Process kworker/0:3 (pid: 4248, stack limit = 0xd0fa0208)
<0>[165140.160223] Stack: (0xd0fa1c38 to 0xd0fa2000)
<0>[165140.160228] 1c20: 0420806c df1f1080
<0>[165140.160236] 1c40: d0fa0000 c08a13e0 df1f1080 00000000 ddb79a40 00000000 c0c59834 c002175c
<0>[165140.160244] 1c60: c00220d4 d0fa1c48 d0fa0000 df1f1080 00000001 00000001 00000001 df1f1078
<0>[165140.160252] 1c80: df1f0000 df1f136c df1f136c c00220d4 00000000 df1f13b4 d0fa1c98 d0fa1c98
<0>[165140.160259] 1ca0: 00000001 c0d03d04 0000000b 00000001 bf1b5bee 00000000 d0fa1d16 bf1b5bec
<0>[165140.160267] 1cc0: 60030113 c00123dc d0fa0208 0000000b c0d0553e 00000000 c0c4e008 00000008
<0>[165140.160275] 1ce0: 00000000 65d04c18 33306133 20303030 61336265 65306434 35336520 30303036
<0>[165140.160283] 1d00: 31652030 30303061 28203530 34393530 38303032 00002029 00000008 b222614a
<0>[165140.160290] 1d20: c0b0c23c 00000008 00000017 d0fa1e38 00000000 df1f1080 00000000 00000017
<0>[165140.160298] 1d40: 00000008 c089bc58 00000008 c0019a04 00000000 c0d05566 c0d0591c 0000ffff
<0>[165140.160306] 1d60: 00000000 bf1d0bf6 00000008 000003e0 c08d7a08 bf1b5bec 00000017 c0c5918c
<0>[165140.160313] 1d80: 00000008 d0fa1e38 c56ab000 c0d00780 00000008 c0008544 00000006 00000058
<0>[165140.160320] 1da0: 00000000 00000058 c0d0b6f0 00000002 00000000 00000000 00005dac c00504dc
<0>[165140.160328] 1dc0: ff0a0005 00000000 00000003 00000006 bf1c7591 00000046 00000006 00000003
<0>[165140.160335] 1de0: c0d0553e c0c5d324 00000046 c0050270 00000046 c0051864 00000000 df5d7320
<0>[165140.160343] 1e00: df5d72fc df5d7314 c0d0553e 0000000f c0c56c00 df740994 00000000 df636000
<0>[165140.160351] 1e20: bf1b5bec 60030113 ffffffff d0fa1e6c 00000000 c0012ba0 d9243c00 d9243c00
<0>[165140.160359] 1e40: 0000888e 000086dd 00000000 d9243c00 00000000 d2a63800 00000000 c56ab000
<0>[165140.160366] 1e60: c0d00780 00000008 00000001 d0fa1e88 bf1bc510 bf1b5bec 60030113 ffffffff
<0>[165140.160374] 1e80: 00000051 00000000 c56aa000 00000023 d2a63808 bf1bc510 c0de8624 c56aa000
<0>[165140.160382] 1ea0: c56ab000 c56ab448 00000023 d3740000 00000000 bf1bc614 d7651600 d3740000
<0>[165140.160390] 1ec0: d765169c 00000100 00000200 bf1be270 d3740000 bf1c6521 d3740000 d37400a0
<0>[165140.160398] 1ee0: d37400a0 00000000 df5d7500 bf1b3a24 d3740000 bf1b6990 d75bd000 de45cc68
<0>[165140.160406] 1f00: d36bae00 bf1c086c d0cf6a80 d374280c c0c5b05c c0035ca0 d0cf6a80 d374280c
<0>[165140.160414] 1f20: 00000001 d0cf6a80 d0fa0000 c0d00498 c0c5b05c c0c5b05c c0c5b06c d0cf6a98
<0>[165140.160421] 1f40: 00000008 c0036adc 00000000 d28d1600 00000000 d0cf6a80 c00367f4 00000000
<0>[165140.160429] 1f60: 00000000 00000000 00000000 c003a2f4 000df841 00000000 2f004620 d0cf6a80
<0>[165140.160437] 1f80: 00000000 d0fa1f84 d0fa1f84 00000001 d0fa1f90 d0fa1f90 d0fa1fac d28d1600
<0>[165140.160444] 1fa0: c003a224 00000000 00000000 c000e058 00000000 00000000 00000000 00000000
<0>[165140.160451] 1fc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
<0>[165140.160458] 1fe0: 00000000 00000000 00000000 00000000 00000013 00000000 eb036b6b 7c9c0381
<4>[165140.160471] [<c003a7e0>] (kthread_data) from [<c0036db8>] (wq_worker_sleeping+0xc/0xb4)
<4>[165140.160482] [<c0036db8>] (wq_worker_sleeping) from [<c08a13e0>] (__schedule+0x118/0x648)
<4>[165140.160492] [<c08a13e0>] (__schedule) from [<c00220d4>] (do_exit+0x958/0x9b0)
<4>[165140.160503] [<c00220d4>] (do_exit) from [<c00123dc>] (die+0x268/0x378)
<4>[165140.160513] [<c00123dc>] (die) from [<c089bc58>] (__do_kernel_fault.part.0+0x54/0x74)
<4>[165140.160524] [<c089bc58>] (__do_kernel_fault.part.0) from [<c0019a04>] (do_page_fault+0x2b8/0x338)
<4>[165140.160534] [<c0019a04>] (do_page_fault) from [<c0008544>] (do_DataAbort+0x34/0x13c)
<4>[165140.160542] [<c0008544>] (do_DataAbort) from [<c0012ba0>] (__dabt_svc+0x40/0x60)
<4>[165140.160546] Exception stack(0xd0fa1e38 to 0xd0fa1e80)
<4>[165140.160550] 1e20: d9243c00 d9243c00
<4>[165140.160558] 1e40: 0000888e 000086dd 00000000 d9243c00 00000000 d2a63800 00000000 c56ab000
<4>[165140.160566] 1e60: c0d00780 00000008 00000001 d0fa1e88 bf1bc510 bf1b5bec 60030113 ffffffff
<4>[165140.160677] [<c0012ba0>] (__dabt_svc) from [<bf1b5bec>] (brcmf_txfinalize+0x70/0x88 [brcmfmac])
<4>[165140.160814] [<bf1b5bec>] (brcmf_txfinalize [brcmfmac]) from [<bf1bc510>] (brcmf_flowring_delete+0x9c/0xac [brcmfmac])
<4>[165140.160945] [<bf1bc510>] (brcmf_flowring_delete [brcmfmac]) from [<bf1bc614>] (brcmf_flowring_detach+0x4c/0x84 [brcmfmac])
<4>[165140.161076] [<bf1bc614>] (brcmf_flowring_detach [brcmfmac]) from [<bf1be270>] (brcmf_proto_msgbuf_detach+0x8c/0xfc [brcmfmac])
<4>[165140.161207] [<bf1be270>] (brcmf_proto_msgbuf_detach [brcmfmac]) from [<bf1b3a24>] (brcmf_proto_detach+0x3c/0x58 [brcmfmac])
<4>[165140.161337] [<bf1b3a24>] (brcmf_proto_detach [brcmfmac]) from [<bf1b6990>] (brcmf_detach+0xb0/0xe0 [brcmfmac])
<4>[165140.161468] [<bf1b6990>] (brcmf_detach [brcmfmac]) from [<bf1c086c>] (brcmf_pcie_reset+0x30/0xc0 [brcmfmac])
<4>[165140.161540] [<bf1c086c>] (brcmf_pcie_reset [brcmfmac]) from [<c0035ca0>] (process_one_work+0x250/0x440)
<4>[165140.161550] [<c0035ca0>] (process_one_work) from [<c0036adc>] (worker_thread+0x2e8/0x42c)
<4>[165140.161560] [<c0036adc>] (worker_thread) from [<c003a2f4>] (kthread+0xd0/0xe4)
<4>[165140.161570] [<c003a2f4>] (kthread) from [<c000e058>] (ret_from_fork+0x14/0x3c)
<0>[165140.161578] Code: e5130018 e7e00150 e12fff1e e5903344 (e5130010)
<4>[165140.161583] ---[ end trace 5dcc204d8eb8bfbb ]---

[Vivek_gunapati]

Hi @vivekpandey 

Could you please give me more details of the setup? 

->Is the kernel crash seen every time when the host wakeup from a suspended state?
-> The host processer used/Linux version used?
-> is the issue reproduceable on the the latest driver/firmware available in the link -> https://community.infineon.com/t5/Wi-Fi-Bluetooth-for-Linux/Cypress-Linux-WiFi-Driver-Release-FMAC-2...

[vivekpandey]

Hi we are using:

/ # wl ver
1.26 RC0.0
wl0: Nov 16 2021 21:03:36 version 13.35.178 (r729425 CY) FWID 01-a5d0ccea
/ #
/ #
/ # uname -a
Linux mifi 3.18.71 #1 PREEMPT Wed Mar 16 05:35:12 PDT 2022 armv7l GNU/Linux

[vivekpandey]

hi,

dmesg log attached.

scenario:

[1]. chipset cyw54591 is used as SoftAP IPic attached).
[2]. Device is running on Battery mode.
[3]. Make 15 clients associate with Device.
[4]. Ubuntu laptop is playing video online, Microsoft surface laptop is doing Remote Service. Other clients are running small traffic.

[5]. Keep the setup overnight.
[6]. On the second day, Plug-in wall charger. Keep about 6-7clients connected to Device.
Meanwhile take 2 clients do out of range test.
[7]. On the third morning, observed Device crashing.

Please let me know where i can create ticket for it?

[Vivek_gunapati]

Hi @vivekpandey 

-> from the command 'wl maxassoc ' we see that the maximum allowed associated station for 54591 is 13. Could you please share with us your output of wl maxassoc ?

->In the above scenario could  you please let us know at which step the system is going to sleep ? and which step is resuming ? What is the trigger to exit from suspend? 

-> is the crash seen with out the suspend/resume enabled.?

[vivekpandey]

-> from the command 'wl maxassoc ' we see that the maximum allowed associated station for 54591 is 13. Could you please share with us your output of wl maxassoc ?

[VP]: / # wl maxassoc
15 (0xf)

->In the above scenario could you please let us know at which step the system is going to sleep ? and which step is resuming ? What is the trigger to exit from suspend?
[VP]:please check dmesg_2. we have cutom app which will periodically put system in suspend (even if wlan is on & screen is off) then after few seconds it will resume. resume can also be invoked by pressing power button which will wake-up screen.

Line 383: 1200.418854: <6> PM: suspend entry 2022-03-29 05:39:37.671613978 UTC
Line 384: 1200.423734: <2> PM: Syncing filesystems ... done.
Line 392: 1200.625630: <6> PM: Wakeup pending, aborting suspend
Line 394: 1200.625724: <6> PM: Some devices failed to suspend, or early wake event detected
Line 400: 1200.804302: <6> PM: resume of devices complete after 178.566 msecs
Line 403: 1200.886880: <6> PM: suspend exit 2022-03-29 05:39:38.139637311 UTC

-> is the crash seen with out the suspend/resume enabled.?
No, we haven;t seen crash is suspend is off.

[Vivek_gunapati]

Thank for the response, could you please update the driver and firmware? the link for the same is found here https://community.infineon.com/t5/Wi-Fi-Bluetooth-for-Linux/Cypress-Linux-WiFi-Driver-Release-FMAC-2...

Please let us know if the issue persists with the latest driver/firmware? as we see that there are changes with respect to the" flowring" files in the latest driver. 

Regards
Vivek

[vivekpandey]

Hi current driver is based on kernel version 4.** but we are running kernel 3.18.

is it ok to integrate new driver with old kernel? 

[Vivek_gunapati]

You can give it a try to compile and load the driver, please let us know if it fails and share the logs. 

[vivekpandey]

Hi,

we gave few tries, attached 2nd compilation blocker log. please post me any link to compile FMAC with kernel 3.18.

thanks.

[Vivek_gunapati]

Thank you for the log,  Could you please confirm if the following was enabled in the kernel's ".config" file  

Edit .config and build cfg80211 as module
CONFIG_CFG80211=m
CONFIG_BCMDHD=n
Disable cfg80211 regdb for the kernel above v5.4.18
CONFIG_CFG80211_REQUIRE_SIGNED_REGDB=n
CONFIG_CFG80211_USE_KERNEL_REGDB_KEYS=n
Enable below configs in .config
CONFIG_ASYMMETRIC_KEY_TYPE=y
CONFIG_ASYMMETRIC_PUBLIC_KEY_SUBTYPE=y
CONFIG_X509_CERTIFICATE_PARSER=y
CONFIG_PKCS7_MESSAGE_PARSER=y

[vivekpandey]

Hi,

thanks for reply. given configurations are already present. Please conform if current backport driver supports 3.18 kernel. ?

if so, please share link to compile backport.

Thanks

[Vivek_gunapati]

Hi @vivekpandey

From the log we see the error  "error: unknown type name 'key_ref_t'" however from the link -> https://elixir.bootlin.com/linux/v3.18/C/ident/key_ref_t we see that the type is defined. 

-> Could you please share us the kernel .config file used ?

-> if so, please share link to compile backport.
 https://www.infineon.com/dgdl/Infineon-AN232689_-_Wi-Fi_software_user_guide-ApplicationNotes-v01_00-...

The above link provides step to integrate the driver to the kernel, You could refer to README file of the the fmac driver package. for more detailed steps. 

[vivekpandey]

Hi, PFA. please delete ext .html

[Vivek_gunapati · Accepted solution]

Thank you for the .config file. 

From the file, we see that below are not set in .config file.
CONFIG_CFG80211=m
CONFIG_BCMDHD=n
CONFIG_ASYMMETRIC_KEY_TYPE=y
CONFIG_ASYMMETRIC_PUBLIC_KEY_SUBTYPE=y
CONFIG_X509_CERTIFICATE_PARSER=y
CONFIG_PKCS7_MESSAGE_PARSER=y

The driver is depended on the the above parameter, if the are enabled the driver modules can be compiled. 

Enabled the above config parameters in .config file,  build the kernel, and build the driver.

Regards
Vivek.

[Vivek_gunapati]

hi @vivekpandey ,

Please let us know if the issue still persist with the above modifications